fix(test): enforce durability invariant after fsync #24
+21
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use crash_info.label to differentiate expected states: - Before fsync: any prefix is acceptable - After fsync: both records MUST be present Addresses review feedback on #23
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback on #23: enforce stricter durability invariant after fsync.
Changes
Use
crash_info.labelto differentiate expected states per crash point:after_write_1,after_write_2): any prefix is acceptableThis catches durability regressions like missing/ignored fsync calls.
Verification
cargo fmt -- --check✅cargo clippy -- -D warnings✅cargo test --test canonical_append_log✅